Android device management revamp

[mihaiblaga89]

Description

• extracted device and sim logic out of running, same as ios now
• reworked the logic a bit
• silenced AVD start it's output was overlapping with other commands
• remove duplicate simulators from target list
• avoid calling checkForActiveEmulator unless needed, it picks up first device found. Now default emu will take precendence unless otherwise specified with -d, -t, etc
• allow empty -t on android, to ask where to run

Testing scope

supported android flags and params, with regards to device management:

• -p android -t - ask from devices and sims
• -p android - run on default from renative.json or ask from devices and sims
• -p android -d - run on device (what happens if few are connected?)
• -p android -d -t - ask from devices
• -p android -t IP:port (device)
• -p android -t emu-name
• -p android -t device-name
• -p android -d -t device-name
• -p android -d -t IP:port (device)

add pin auth support. Split in separate ticket if takes longer

Related issues

• Rnv can't find active emulators/simulators #1022
• [Android, AndroidTV, Androidewear] dupicates of target list when device is active #1202
• If there is androidtv connected, you can't run on emulator anymore #1025
• Newer android devices need pairing before able to connect to device over network #1067
• Add default device option for device management #1270

Npm releases

n/a

[GabrieleKaceviciute]

• target list works as expected

• -p android -t, -p android -> finds only active devices/emulators if there is even one active devices/emu. If there is no active devices/emulators - shows all inactive emulators

• -p android -d -> no questions on cli, but app installed on every active devices/emulators even on tv and watch (e.g. connect device with cable and open emu) (seems same as on this ticket Android and Android TV instances are overriding each others app #1249)

• -p android -t emu-name , -p android -t device-name , -p android -d -t device-name -> no questions on cli, but app installed on every active devices and emulators

• -p android -t IP:port -> can't check adb issue

[pauliusguzas]

no device connected, one active sim:
FAIL -p android -t - if there is an active sim, shows only it
PASS -p android - runs on default sim
FAIL -p android -d - runs on default sim
FAIL -p android -d -t - asks to choose from sims (if there is an active sim, shows only it)
PASS -p android -t emu-name - runs on specified sim

device connected:
FAIL -p android -t - shows only active sims/devices

FAIL -p android - installs to device and sim (launches on sim)
FAIL -p android -d - installs to device and sim (launches on device)
FAIL -p android -d -t - ask from devices, installs to both (launches device)
FAIL -p android -t IP:port (device) installs to both (launches device)
FAIL -p android -t emu-name - installs to both (launches device)
FAIL -p android -t device-name - installs to both (launches device)
FAIL -p android -d -t device-name - installs to both (launches device)
FAIL -p android -d -t IP:port (device) - installs to both (launches device)

[pauliusguzas]

Latest test results are in https://docs.google.com/spreadsheets/d/1lc8p6TmH_wuoO-AK5-b_XmnrlhSzkai7EM7EHHKmCZw/edit#gid=611100217 on RNV_linked_repo_mac86 tab

[pauliusguzas]

All major issues fixed, things remaining:

1. No default device feature Add default device option for device management #1270
2. No rnv pairing support Newer android devices need pairing before able to connect to device over network #1067
3. In few cases on simulators sometimes app is installed but not launched, usually solved by cold boot of sim or restart of sim
4. Android and Android TV instances are overriding each others app #1249 - app is installed on every android based platform when ran