-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kaios simulator on linux #1450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavjacko
requested changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Marius456
make sure your husky commit hooks running correctly or you do not commit final changes with --no-verify
which disables local checks.
renative/packages/sdk-kaios/src/deviceManager.ts
1:37 error 'chalk' is defined but never used @typescript-eslint/no-unused-vars
1:78 error 'logError' is defined but never used @typescript-eslint/no-unused-vars
1:88 error 'executeAsync' is defined but never used @typescript-eslint/no-unused-vars
1:102 error 'logSuccess' is defined but never used @typescript-eslint/no-unused-vars
16:13 error 'availableSimulatorVersions' is never reassigned. Use 'const' instead prefer-const
you can check this manually as well by running yarn sanity
Merged
mihaiblaga89
suggested changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Npm releases
n/a
NOTE:
test this PR following following: