Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/android resources #1476

Merged
7 commits merged into from
Apr 8, 2024
Merged

Fix/android resources #1476

7 commits merged into from
Apr 8, 2024

Conversation

ElenaDiachenko
Copy link
Contributor

@ElenaDiachenko ElenaDiachenko commented Mar 19, 2024

Description

  • change res/values files generation (generated by ReNative)
  • styles_xml config prop not taken into account
  • colors_xml config prop not taken into account

Related issues

Example

 "platforms": {
        "android": {
            "templateAndroid": {
                "styles_xml": {
                    "tag": "resources",
                    "children": [
                        {
                            "tag": "style",
                            "name": "AppTheme",
                            "children": [
                                {
                                    "tag": "item",
                                    "name": "android:windowIsTranslucent",
                                    "value": "true"
                                }
                            ]
                        }
                    ]
                },
                "colors_xml": {
                    "tag": "resources",
                    "children": [{ "tag": "color", "name": "bg", "value": "#FFBF00" }]
                }
            }
        }
    },

Npm releases

n/a

@ElenaDiachenko ElenaDiachenko self-assigned this Mar 19, 2024
@pauliusguzas pauliusguzas added e2e and removed e2e labels Mar 20, 2024
@ElenaDiachenko ElenaDiachenko requested a review from pavjacko March 25, 2024 08:21
@pavjacko pavjacko self-assigned this Mar 26, 2024
@pavjacko pavjacko closed this pull request by merging all changes into release/1.0 in db532aa Apr 8, 2024
@Marius456 Marius456 deleted the fix/android_resources branch August 23, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants