Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix skip linking for native plugins #1502

Merged
merged 4 commits into from
Apr 10, 2024
Merged

fix skip linking for native plugins #1502

merged 4 commits into from
Apr 10, 2024

Conversation

ElenaDiachenko
Copy link
Contributor

Description

  • rnv doesn’t take into account supportedPlatforms when generating a list of plugins to disable autolinking
  • plugins.supportedPlatforms have wrong description in the schema

Related issues

n/a

Npm releases

n/a

@ElenaDiachenko ElenaDiachenko self-assigned this Apr 10, 2024
@ElenaDiachenko ElenaDiachenko added this to the 1.0 milestone Apr 10, 2024
@ElenaDiachenko ElenaDiachenko added e2e and removed e2e labels Apr 10, 2024
pavjacko
pavjacko requested changes Apr 10, 2024
View reviewed changes
packages/sdk-react-native/src/env.ts Outdated Show resolved Hide resolved
@pavjacko pavjacko merged commit bd3fca9 into release/1.0 Apr 10, 2024
1 check passed
@pavjacko pavjacko deleted the fix/linking_for_unsupported_plugins branch April 10, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavjacko pavjacko pavjacko approved these changes

Assignees

@ElenaDiachenko ElenaDiachenko

Labels
e2e
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ElenaDiachenko @pavjacko