Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create android simulator error #1548

Merged
merged 11 commits into from
May 15, 2024
Merged

Conversation

Marius456
Copy link
Contributor

Description

  • While creating simulator, it doesn't take into account cpu

Related issues

Npm releases

n/a

@Marius456 Marius456 self-assigned this May 8, 2024
@Marius456 Marius456 added this to the 1.0 milestone May 8, 2024
@Marius456 Marius456 added the e2e label May 8, 2024
@Marius456 Marius456 marked this pull request as draft May 8, 2024 11:16
@Marius456 Marius456 marked this pull request as ready for review May 9, 2024 05:25
@Marius456 Marius456 added e2e and removed e2e labels May 9, 2024
@GabrieleKaceviciute
Copy link
Collaborator

I've tested on macOS Ventura 13.6.4 (M2) ->
android -> simulator created
androidwear -> simulator created
androidtv -> error

➜  template-starter git:(fix/create_android_sim) npx rnv run -p androidtv -r

┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝ │
│ ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗   │
│ ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝   │
│ ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗ │
│ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝ │
│ 🚀 v:1.0.0-rc.18 | renative.org | 5/9/2024, 11:41:53 AM         │
│ $ rnv run -p androidtv -r                                       │
└─────────────────────────────────────────────────────────────────┘
info: Current engine: @rnv/engine-rn-tvos (../engine-rn-tvos)
task: ○ run ↺1
info: Build hooks not complied. BUILDING...
task: ○ configure ↺1
task: ○ platform configure ↺1
task: ○ project configure ↺1
task: ○ workspace configure ↺1
task: ✔ workspace configure
task: ○ app configure ↺1
info: Current app config: template
task: ✔ app configure
info: ../../node_modules/react-native-tvos/Libraries/Components/ScrollView/ScrollViewNativeComponent.js overriden by: /@rnv/config-templates/pluginTemplates/react-native-tvos/overrides.json
info: ../../node_modules/react-native-tvos/Libraries/Components/ScrollView/ScrollViewNativeComponent.js overriden by: /@rnv/config-templates/pluginTemplates/react-native-tvos/overrides.json
info: ../../node_modules/react-native-tvos/Libraries/Components/ScrollView/ScrollViewNativeComponent.js overriden by: /@rnv/config-templates/pluginTemplates/react-native-tvos/overrides.json
info: ../../node_modules/@react-native-community/cli-platform-ios/build/tools/listIOSDevices.js overriden by: /@rnv/config-templates/pluginTemplates/@react-native-community/cli-platform-ios/overrides@11.3.7.json
info: ../../node_modules/@react-native-community/cli/build/bin.js overriden by: /@rnv/config-templates/pluginTemplates/@react-native-community/cli/overrides.json
task: ✔ project configure
info: Current Build Scheme: debug
task: ○ sdk configure ↺1
task: ✔ sdk configure
info: You passed -r argument. "./platformBuilds/template_androidtv" CLEANING...DONE
task: ✔ platform configure
info: Found custom assetFolderPlatform: android. Will use it instead of deafult androidtv
info: Found custom assetSources at ../../node_modules/@flexn/assets-renative-outline/assets/android. Will be used to generate assets.
task: ✔ configure
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb devices -l
✔ Executing: /Users/gabriele/Library/Android/sdk/emulator/emulator -list-avds
? Do you want ReNative to create new Emulator (Television_1080p_API_31) for you? Yes
✖ FAILED: /Users/gabriele/Library/Android/sdk/cmdline-tools/latest/bin/sdkmanager "system-images;android-30;android-tv;arm64-v8a"
error: ⨯ ○ run: COMMAND:

/Users/gabriele/Library/Android/sdk/cmdline-tools/latest/bin/sdkmanager "system-images;android-30;android-tv;arm64-v8a"

FAILED with ERROR:

Loading package information... Loading local repository... [ ] 3% Loading local repository... [ ] 3% Fetch remote repository... [= ] 3% Fetch remote repository... [= ] 3% Fetch remote repository... [= ] 3% Fetch remote repository... Warning: Errors during XML parse:
Warning: Additionally, the fallback loader failed to parse the XML.
[= ] 4% Fetch remote repository... [= ] 5% Fetch remote repository... [== ] 5% Fetch remote repository... [== ] 6% Fetch remote repository... [== ] 7% Fetch remote repository... [== ] 7% Computing updates... [=== ] 8% Computing updates... [=== ] 10% Computing updates... [=== ] 10% Computing updates... Warning: Failed to find package 'system-images;android-30;android-tv;arm64-v8a'

Error: Command failed with exit code 1: /Users/gabriele/Library/Android/sdk/cmdline-tools/latest/bin/sdkmanager "system-images;android-30;android-tv;arm64-v8a"
Warning: Errors during XML parse:
Warning: Additionally, the fallback loader failed to parse the XML.
Warning: Failed to find package 'system-images;android-30;android-tv;arm64-v8a'
[===                                    ] 10% Computing updates...
    at makeError (/Users/gabriele/Desktop/tests/renative/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/Users/gabriele/Desktop/tests/renative/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Warning: Errors during XML parse:       ] 3% Fetch remote repository...
Warning: Additionally, the fallback loader failed to parse the XML.
Warning: Failed to find package 'system-images;android-30;android-tv;arm64-v8a'


error: ⨯ ○ run: COMMAND:

/Users/gabriele/Library/Android/sdk/emulator/emulator -avd Television_1080p_API_31

FAILED with ERROR:

Error: Command failed with exit code 1: /Users/gabriele/Library/Android/sdk/emulator/emulator -avd Television_1080p_API_31
    at makeError (/Users/gabriele/Desktop/tests/renative/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/Users/gabriele/Desktop/tests/renative/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)


✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb devices -l
looking for active emulators: attempt 1/10
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb kill-server
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb start-server
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb devices -l
looking for active emulators: attempt 2/10
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb devices -l
looking for active emulators: attempt 3/10
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb devices -l
looking for active emulators: attempt 4/10
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb devices -l
looking for active emulators: attempt 5/10
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb devices -l
looking for active emulators: attempt 6/10
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb devices -l
looking for active emulators: attempt 7/10
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb devices -l
looking for active emulators: attempt 8/10
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb devices -l
looking for active emulators: attempt 9/10
✔ Executing: /Users/gabriele/Library/Android/sdk/platform-tools/adb devices -l
looking for active emulators: attempt 10/10
error: ⨯ ○ run: Could not find any active emulators
┌─────────────────────────────────────────────────────────────────┐
│ ⨯ SUMMARY | 5/9/2024, 11:42:48 AM | rnv@1.0.0-rc.18             │
│ $ rnv run -p androidtv -r                                       │
├─────────────────────────────────────────────────────────────────┤
│ Project: @rnv/template-starter@1.0.0-rc.18                      │
│ Workspace: rnv                                                  │
│ Platform (-p): androidtv                                        │
│ Engine: @rnv/engine-rn-tvos                                     │
│ App Config (-c): template                                       │
│ Build Scheme (-s): debug                                        │
│ Target (-t): Television_1080p_API_31                            │
│ Reset Project (-r): true                                        │
│ Supported Platforms: ios, android, androidtv, firetv, androidwear, web, tizen, tvos, webos, macos, tizenwatch, kaios, chromecast, linux
│ Env Info: darwin | arm64 | node v18.19.0                        │
│ Executed Time: 0h:0m:54s:580ms                                  │
│ error: ⨯ ○ run: COMMAND:

/Users/gabriele/Library/Android/sdk/cmdline-tools/latest/bin/sdkmanager "system-images;android-30;android-tv;arm64-v8a"

FAILED with ERROR:

Loading package information... Loading local repository... [ ] 3% Loading local repository... [ ] 3% Fetch remote repository... [= ] 3% Fetch remote repository... [= ] 3% Fetch remote repository... [= ] 3% Fetch remote repository... Warning: Errors during XML parse:
Warning: Additionally, the fallback loader failed to parse the XML.
[= ] 4% Fetch remote repository... [= ] 5% Fetch remote repository... [== ] 5% Fetch remote repository... [== ] 6% Fetch remote repository... [== ] 7% Fetch remote repository... [== ] 7% Computing updates... [=== ] 8% Computing updates... [=== ] 10% Computing updates... [=== ] 10% Computing updates... Warning: Failed to find package 'system-images;android-30;android-tv;arm64-v8a'

Error: Command failed with exit code 1: /Users/gabriele/Library/Android/sdk/cmdline-tools/latest/bin/sdkmanager "system-images;android-30;android-tv;arm64-v8a"
Warning: Errors during XML parse:
Warning: Additionally, the fallback loader failed to parse the XML.
Warning: Failed to find package 'system-images;android-30;android-tv;arm64-v8a'
[===                                    ] 10% Computing updates...
    at makeError (/Users/gabriele/Desktop/tests/renative/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/Users/gabriele/Desktop/tests/renative/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Warning: Errors during XML parse:       ] 3% Fetch remote repository...
Warning: Additionally, the fallback loader failed to parse the XML.
Warning: Failed to find package 'system-images;android-30;android-tv;arm64-v8a'


│ error: ⨯ ○ run: COMMAND:

/Users/gabriele/Library/Android/sdk/emulator/emulator -avd Television_1080p_API_31

FAILED with ERROR:

Error: Command failed with exit code 1: /Users/gabriele/Library/Android/sdk/emulator/emulator -avd Television_1080p_API_31
    at makeError (/Users/gabriele/Desktop/tests/renative/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/Users/gabriele/Desktop/tests/renative/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)


│ error: ⨯ ○ run: Could not find any active emulators
│ Project location: ./platformBuilds/template_androidtv           │
└─────────────────────────────────────────────────────────────────┘
➜  template-starter git:(fix/create_android_sim)

@Marius456 Marius456 marked this pull request as draft May 9, 2024 09:44
@Marius456 Marius456 marked this pull request as ready for review May 14, 2024 05:08
@Marius456 Marius456 added e2e and removed e2e labels May 14, 2024
@Marius456 Marius456 marked this pull request as draft May 14, 2024 07:43
@Marius456 Marius456 added e2e and removed e2e labels May 14, 2024
@Marius456 Marius456 added e2e and removed e2e labels May 14, 2024
@Marius456 Marius456 marked this pull request as ready for review May 14, 2024 10:53
@GabrieleKaceviciute GabrieleKaceviciute self-requested a review May 14, 2024 11:42
@Marius456 Marius456 added e2e and removed e2e labels May 14, 2024
@pavjacko pavjacko merged commit 1c08347 into release/1.0 May 15, 2024
1 check passed
@pavjacko pavjacko deleted the fix/create_android_sim branch May 15, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants