Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/exclude dirs for webpack #1551

Merged
merged 5 commits into from
May 23, 2024
Merged

Conversation

ElenaDiachenko
Copy link
Contributor

@ElenaDiachenko ElenaDiachenko commented May 12, 2024

Description

  • webpack does not exclude src/pages when bundling code for web platforms that do not use next.js.
  • improved webpack merging

Related issues

  • GH issues

Npm releases

n/a

@ElenaDiachenko ElenaDiachenko marked this pull request as draft May 12, 2024 22:42
@ElenaDiachenko ElenaDiachenko changed the base branch from release/1.0 to fix/rnv_run_new_project May 13, 2024 06:19
@ElenaDiachenko ElenaDiachenko changed the base branch from fix/rnv_run_new_project to release/1.0 May 13, 2024 06:56
@ElenaDiachenko ElenaDiachenko marked this pull request as ready for review May 15, 2024 07:34
@ElenaDiachenko
Copy link
Contributor Author

@pauliusguzas
Steps for checking:

  1. Create a new project with support for macos
  2. Run macos => expected issue:
TS2307: Cannot find module 'next/document' or its corresponding type declarations.
  > 1 | import Document, { Html, Head, Main, NextScript } from 'next/document';
      |                                                        ^^^^^^^^^^^^^^^
    2 | import React from 'react';
    3 | import { CONFIG } from '../config';
    4 | 
  1. Do rnv link.
  2. Run macos again => successfully and without error

@ElenaDiachenko ElenaDiachenko self-assigned this May 22, 2024
@ElenaDiachenko ElenaDiachenko added this to the 1.0 milestone May 22, 2024
@pauliusguzas pauliusguzas self-requested a review May 22, 2024 11:56
@pauliusguzas pauliusguzas added e2e and removed e2e labels May 22, 2024
@pavjacko pavjacko merged commit 08e928d into release/1.0 May 23, 2024
11 checks passed
@pavjacko pavjacko deleted the fix/exclude_dirs_for_webpack branch May 23, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants