Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cli #1614

Merged
merged 9 commits into from
Jul 1, 2024
Merged

Fix/cli #1614

merged 9 commits into from
Jul 1, 2024

Conversation

ElenaDiachenko
Copy link
Contributor

@ElenaDiachenko ElenaDiachenko commented Jun 21, 2024

Description

  • fixed output when using --mono and --json;
  • fixed program options to support both hyphenated and camelCase values;
  • added --no-summary ( --noSummary ) and --no-intro ( --noIntro ) options

Related issues

Npm releases

n/a

@ElenaDiachenko ElenaDiachenko added this to the 1.0 milestone Jun 21, 2024
@ElenaDiachenko ElenaDiachenko self-assigned this Jun 26, 2024
@ElenaDiachenko ElenaDiachenko added e2e and removed e2e labels Jun 26, 2024
@pauliusguzas pauliusguzas self-requested a review June 27, 2024 11:18
Copy link
Collaborator

@pauliusguzas pauliusguzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--no-color/--mono doesn't ignore all colors
Screenshot 2024-06-27 at 13 46 30
Screenshot 2024-06-27 at 13 46 37
--noColor doesn't work at all (no affect)
npx rnv run -p web --no-default - should ask to choose config, scheme and many things -> does nothing
rnv info prints weird stuff
rnv update not supported

questions:

  1. how to test --answers <value>
  2. what is expected in each of these:
Screenshot 2024-06-27 at 14 18 00

@pauliusguzas pauliusguzas self-requested a review June 28, 2024 09:19
@pavjacko pavjacko merged commit 5a148ac into release/1.0 Jul 1, 2024
1 check passed
@pavjacko pavjacko deleted the fix/cli branch July 1, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants