Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/compare plugin overrides #1628

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Feat/compare plugin overrides #1628

merged 6 commits into from
Jul 23, 2024

Conversation

locksten
Copy link
Collaborator

@locksten locksten commented Jul 15, 2024

Description

Adds a script for pulling in plugin overrides from external sources.
Running npx rnv hooks run -x comparePluginOverrides ./packages/config-templates/pluginTemplates ~/other-project/packages/plugins/pluginTemplates displays the plugin overrides present in the other project and whether they match our overrides, are different, or new. It also displays a summary of the file changes, related commit messages, and which version of the plugin we're using. The script can also be used to interactively apply the overrides from the other project.

summary
review

Copy link
Collaborator

@RicardasN RicardasN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily the most informed review as I only looked at it from code perspective, did not test it and probably it would be good for QA to check, but looks good in my opinion

buildHooks/src/comparePluginOverrides.ts Show resolved Hide resolved
@locksten locksten changed the base branch from release/1.0 to main July 22, 2024 07:31
@pavjacko pavjacko added this to the 1.1 milestone Jul 23, 2024
@pavjacko pavjacko merged commit ea15048 into main Jul 23, 2024
11 checks passed
@pavjacko pavjacko deleted the feat/compare-plugin-overrides branch July 23, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants