Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve metro config merging #1770

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

vvsamin
Copy link
Contributor

@vvsamin vvsamin commented Oct 26, 2024

Description

There are problems with merging metro configs (some properties are overwritten).

For example:

module.exports = withRNVMetro({
    resolver: {
        sourceExts: ['svg'],
    }
})

as a result, the merged config contains only the custom sourceExts array, losing all rnv extensions (although initially, the logic implied unifying some of the properties).

This PR fixes such errors and improves the config merge flow.

Related issues

  • GH issues

Npm releases

n/a

@pauliusguzas pauliusguzas self-requested a review October 29, 2024 08:05
@pauliusguzas pauliusguzas merged commit 5308230 into flexn-io:main Oct 29, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants