fix/defaultTargets_updating #1782

ElenaDiachenko · 2024-11-12T07:04:15Z

Description

On Android, AndroidTV, fireTV, AndroidWear, Tizen, Tizenwatch platforms defaultTarget object of .rnv/renative.json isn't updated with default platforms

Related issues

[Android, AndroidTV, fireTV, AndroidWear, Tizen, Tizenwatch, (kaiOS?)] Default target isn't updated #1778

Npm releases

n/a

GabrieleKaceviciute · 2024-11-12T08:51:46Z

On android platforms (android, androidTV, androidwear, firetv) rnv asks ->

? What target would you like to use? Television_1080p_API_31 | TV 📺  | arch: arm64-v8a | udid: unknown
? Your default target for platform firetv is not defined. Do you want to set it to Television_1080p_API_31  Yes

On ios and tvos ->

? No global or project default simulator or device defined. Please select a supported simulator to use iPhone 16 | Phone 📱 | v: 1
8.1 (22B81) | udid: CCD32DDF-CC9D-44C8-8E4A-0CA1CD4623A7
warn: ○ run: Your default target for platform ios is set to undefined.
? What to do next? (Use arrow keys)
❯ Update project default target for platform ios
  Update global default target for platform ios
  Don't update

Note: On webos -> didn't ask to choose target (I have only one webos simulator installed)

info: Found simulator webOS_TV_24_Simulator_1.4.1 in ../../../../../webOS_TV_SDK/Simulator
? Your default target for platform webos is not defined. Do you want to set it to webOS_TV_24_Simulator_1.4.1  (Y/n)

Is it expected that android target is set on global but ios you could choose?

pauliusguzas · 2024-11-12T10:01:42Z

tizen, tizenwatch isn't installed when user chooses any answer. And also same as on android, no way to choose where to set default target

packages/sdk-tizen/src/deviceManager.ts

+                return true;
+            } else {
+                await executeAsync(
+                    `${c.cli[CLI_TIZEN_EMULATOR]} launch --name ${name}`,


To fix the problem, we should avoid constructing the shell command using string concatenation with untrusted input. Instead, we can use the child_process.execFile method, which allows us to pass arguments as an array, thus avoiding shell interpretation of the input.

Replace the use of executeAsync with execFile from the child_process module.

Ensure that the name parameter is passed as an argument in the array format to execFile.

GabrieleKaceviciute · 2024-11-14T11:58:42Z

webos -> need to ask to choose target before where to set default target
tizen -> app doesn't installed on simulator whatever you choose
error on CLI:

? which emulator or device would you like to launch? T-8.0-x86_64


warn: ○ run: Your default target for platform tizen is not defined.
? What to do next? Update project default target for platform tizen
√ Executing: "C:\tizen-studio\tools\sdb.exe" devices
√ Executing: C:\tizen-studio\tools\emulator\bin\em-cli.bat launch --name T-8.0-x86_64
× Can't connect to the running emulator. Try restarting it.
? Could not find or connect to the specified target (T-8.0-x86_64

). Would you like to start an emulator? Yes
error: ⨯ ○ run: No default target found for tizen. please provide one using -t option

NOTE: project/global default target updates like this -> "defaultTargets": { "tizen": "T-8.0-x86_64\r" } but simulator name is "T-8.0-x86_64" (without "\r")

Tizenwatch -> works as expected.
Tizen, tizenwatch tested on windows

pauliusguzas · 2024-11-14T13:41:24Z

on mac both tizen and tizenwatch work as expected

GabrieleKaceviciute · 2024-11-15T15:52:32Z

windows

Tizen -> fails the first time after yarn bootstrap ( doesn't matter what I choose (update global / update project / don't update)) -> tizen simulator opens, but app doesn't installed, and simulator closes when this error occurs on CLI

? which emulator or device would you like to launch? T-8.0-x86_64
warn: ○ run: Your default target for platform tizen is not defined.
? What to do next? Update project default target for platform tizen
√ Executing: "C:\tizen-studio\tools\sdb.exe" devices
√ Executing: C:\tizen-studio\tools\emulator\bin\em-cli.bat launch --name T-8.0-x86_64
√ Waiting for emulator to boot...
√ Executing: "C:\tizen-studio\tools\ide\bin\tizen.bat" build-web -- "C:\Users\dev\Desktop\qa\renative\packages\template-starter\platformBuilds\template_tizen" -out "C:\Users\dev\Desktop\qa\renative\packages\template-starter\platformBuilds\template_tizen\intermediate"
√ Executing: "C:\tizen-studio\tools\ide\bin\tizen.bat" package -- "C:\Users\dev\Desktop\qa\renative\packages\template-starter\platformBuilds\template_tizen\intermediate" -s RNVanillaCert -t wgt -o "C:\Users\dev\Desktop\qa\renative\packages\template-starter\platformBuilds\template_tizen\output"
√ Executing: "C:\tizen-studio\tools\ide\bin\tizen.bat" uninstall -p NkVRhWHJSX.RNVanillaTV -t T-8.0-x86_64
√ Executing: "C:\tizen-studio\tools\ide\bin\tizen.bat" install -- "C:\Users\dev\Desktop\qa\renative\packages\template-starter\platformBuilds\template_tizen\output" -n RNVanillaTV.wgt -t T-8.0-x86_64
× FAILED: "C:\tizen-studio\tools\ide\bin\tizen.bat" run -p NkVRhWHJSX -t T-8.0-x86_64
This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
No emulator -t target name specified!
No emulator -t target name specified!
PS C:\Users\dev\Desktop\qa\renative\packages\template-starter>

NOTE - project/global default target updates correctly

macOS ->
If you choose "update global" -> app installed to simulator but doesn't launches. If you try to launch manually - crashes.

pauliusguzas · 2024-11-18T04:37:52Z

Not implemented on kaios

pauliusguzas · 2024-11-25T08:53:41Z

tizen, tizenwatch, webos works without issues. Kaios never asks to choose default target (I currently have only one kaios sim, so maybe there is connection?). Also kaios sim is searched on weird path, see picture, there is "false" directory added

fix/defaultTargets_updating

b803d0d

ElenaDiachenko added this to the 1.7 milestone Nov 12, 2024

ElenaDiachenko self-assigned this Nov 12, 2024

add default workspace config

e491e5a

GabrieleKaceviciute self-requested a review November 12, 2024 07:58

GabrieleKaceviciute added the e2e label Nov 12, 2024

pauliusguzas requested a review from Marius456 November 12, 2024 08:03

Marius456 approved these changes Nov 12, 2024

View reviewed changes

fix

3818417

github-advanced-security bot found potential problems Nov 14, 2024

View reviewed changes

fix webos

bc069a0

pauliusguzas added e2e and removed e2e labels Nov 15, 2024

Marius456 marked this pull request as draft November 15, 2024 08:01

ElenaDiachenko added 2 commits November 15, 2024 15:41

fix tizen

ff1530b

clean code

1b7722a

ElenaDiachenko added 3 commits November 21, 2024 14:24

fix tizen

9171858

update to main

742d9db

fix webos and kaios

3230fc6

ElenaDiachenko marked this pull request as ready for review November 24, 2024 14:56

clean code

f06d9d4

Marius456 added e2e and removed e2e labels Nov 25, 2024

GabrieleKaceviciute removed their request for review November 25, 2024 08:14

GabrieleKaceviciute requested a review from pauliusguzas November 25, 2024 08:14

removed kaios default target update functionality

21e8a8b

pauliusguzas approved these changes Nov 26, 2024

View reviewed changes

pauliusguzas merged commit d2b4189 into main Nov 26, 2024
3 checks passed

ElenaDiachenko deleted the fix/defaultTargets_updating branch December 3, 2024 06:52

@@ -139,6 +139,12 @@
                         } else {
-                            await executeAsync(
-                                `${c.cli[CLI_TIZEN_EMULATOR]} launch --name ${name}`,
-                                ExecOptionsPresets.SPINNER_FULL_ERROR_SUMMARY
-                            );
+                            const { execFile } = require('child_process');
+                            await new Promise((resolve, reject) => {
+                                execFile(c.cli[CLI_TIZEN_EMULATOR], ['launch', '--name', name], ExecOptionsPresets.SPINNER_FULL_ERROR_SUMMARY, (error, stdout, stderr) => {
+                                    if (error) {
+                                        reject(error);
+                                    } else {
+                                        resolve(stdout);
+                                    }
+                                });
+                            });
                             return true;

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix/defaultTargets_updating #1782

fix/defaultTargets_updating #1782

ElenaDiachenko commented Nov 12, 2024

GabrieleKaceviciute commented Nov 12, 2024 •

edited

Loading

pauliusguzas commented Nov 12, 2024 •

edited

Loading

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

GabrieleKaceviciute commented Nov 14, 2024

pauliusguzas commented Nov 14, 2024

GabrieleKaceviciute commented Nov 15, 2024 •

edited

Loading

pauliusguzas commented Nov 18, 2024

pauliusguzas commented Nov 25, 2024

fix/defaultTargets_updating #1782

fix/defaultTargets_updating #1782

Conversation

ElenaDiachenko commented Nov 12, 2024

Description

Related issues

Npm releases

GabrieleKaceviciute commented Nov 12, 2024 • edited Loading

pauliusguzas commented Nov 12, 2024 • edited Loading

GabrieleKaceviciute commented Nov 14, 2024

pauliusguzas commented Nov 14, 2024

GabrieleKaceviciute commented Nov 15, 2024 • edited Loading

pauliusguzas commented Nov 18, 2024

pauliusguzas commented Nov 25, 2024

GabrieleKaceviciute commented Nov 12, 2024 •

edited

Loading

pauliusguzas commented Nov 12, 2024 •

edited

Loading

GabrieleKaceviciute commented Nov 15, 2024 •

edited

Loading