Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/overrides_when_version_changes + add --skipOverridesCheck #1800

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

ElenaDiachenko
Copy link
Contributor

@ElenaDiachenko ElenaDiachenko commented Nov 25, 2024

Description

  • the functionality of applying overrides does not work correctly when changing the version of rnv
  • postinstall script tries to use non-existent .rnv folder => yarn execution fails with error in a cloned renative project:
[4/4] 🔨  Building fresh packages...
$ node scripts/postinstall.js
error: ⨯  Error: ENOENT: no such file or directory, mkdir '/Users/pauliusguzas/Desktop/random_testai/hello-renative/.rnv/overrides'
    at Object.mkdirSync (node:fs:1398:3)
    at fsMkdirSync (/Users/pauliusguzas/Desktop/random_testai/hello-renative/node_modules/@rnv/core/src/system/fs.ts:56:66)
    at _ensureOverrideDirExists (/Users/pauliusguzas/Desktop/random_testai/hello-renative/node_modules/@rnv/core/src/plugins/index.ts:981:20)
    at overrideFileContents (/Users/pauliusguzas/Desktop/random_testai/hello-renative/node_modules/@rnv/core/src/plugins/index.ts:793:25)
    at /Users/pauliusguzas/Desktop/random_testai/hello-renative/node_modules/@rnv/core/src/plugins/index.ts:751:45
    at Array.forEach (<anonymous>)
    at /Users/pauliusguzas/Desktop/random_testai/hello-renative/node_modules/@rnv/core/src/plugins/index.ts:743:36
    at Array.forEach (<anonymous>)
    at _overridePlugin (/Users/pauliusguzas/Desktop/random_testai/hello-renative/node_modules/@rnv/core/src/plugins/index.ts:690:22)
    at /Users/pauliusguzas/Desktop/random_testai/hello-renative/node_modules/@rnv/core/src/plugins/index.ts:1108:25
  • add --skipOverridesCheck option to skip applying plugin overrides. Useful for avoiding unnecessary checks on every run when overrides are already applied.

Related issues

Npm releases

n/a

@ElenaDiachenko ElenaDiachenko added this to the 1.8 milestone Nov 25, 2024
@ElenaDiachenko ElenaDiachenko self-assigned this Nov 25, 2024
@Marius456 Marius456 added the e2e label Nov 26, 2024
@Marius456 Marius456 added e2e and removed e2e labels Nov 26, 2024
@ElenaDiachenko ElenaDiachenko changed the title fix/overrides_when_version_changes fix/overrides_when_version_changes + add --skipOverridesCheck Nov 27, 2024
@pauliusguzas pauliusguzas added e2e and removed e2e labels Nov 27, 2024
@pauliusguzas pauliusguzas merged commit ed0ea0f into main Nov 29, 2024
12 of 13 checks passed
@pauliusguzas pauliusguzas deleted the fix/overrides_when_version_changes branch November 29, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants