-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/supportedPlatforms_detection #1801
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauliusguzas
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same bug not sorted
pauliusguzas@MBP-de-Flexn Desktop % npx rnv new --projectName app --workspace appgyver --title app --id com.mycompany.app --appVersion 0.1.0 --local-template-path ~/Desktop/renative/renative/packages/template-starter --ci --yes
┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗ ██╗ █████╗ ████████╗██╗██╗ ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗ ██║██╔══██╗╚══██╔══╝██║██║ ██║██╔════╝ │
│ ██████╔╝█████╗ ██╔██╗ ██║███████║ ██║ ██║██║ ██║█████╗ │
│ ██╔══██╗██╔══╝ ██║╚██╗██║██╔══██║ ██║ ██║╚██╗ ██╔╝██╔══╝ │
│ ██║ ██║███████╗██║ ╚████║██║ ██║ ██║ ██║ ╚████╔╝ ███████╗ │
│ ╚═╝ ╚═╝╚══════╝╚═╝ ╚═══╝╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═══╝ ╚══════╝ │
│ 🚀 v:1.7.0-rc.0 | renative.org | 27/11/2024, 11:22:18 │
│ $ rnv new --projectName app --workspace appgyver --title app --id com.mycompany.app --appVersion 0.1.0 --local-template-path /Users/pauliusguzas/Desktop/renative/renative/packages/template-starter --ci --yes
└─────────────────────────────────────────────────────────────────┘
info: Current engine: @rnv/engine-core (./renative/renative/packages/engine-core/lib)
task: ○ new ↺1
warn: Folder ./app already exists. RNV will override it.
info: Cleaning up existing folder...
info: Found local template: @rnv/template-starter@1.7.0-rc.0
✔ Executing: yarn
✔ Executing: yarn add @rnv/config-templates@1.7.0-rc.0 --dev
info: Missing directory ./app/buildHooks. COPYING from TEMPLATE...DONE
info: Missing directory ./app/src/app. COPYING from TEMPLATE...DONE
info: Missing directory ./app/src/entry. COPYING from TEMPLATE...DONE
info: Missing file ./app/src/config.tsx. COPYING from TEMPLATE...DONE
info: Missing file ./app/index.js. COPYING from TEMPLATE...DONE
info: Missing file ./app/tsconfig.json. COPYING from TEMPLATE...DONE
info: Missing file ./app/babel.config.js. COPYING from TEMPLATE...DONE
info: Missing directory ./app/typings. COPYING from TEMPLATE...DONE
info: Missing file ./app/.gitignore. COPYING from TEMPLATE...DONE
info: Missing directory ./app/appConfigs/app. COPYING from TEMPLATE...DONE
info: Missing directory ./app/appConfigs/base/assets. COPYING from TEMPLATE...DONE
info: Missing directory ./app/appConfigs/base/fonts. COPYING from TEMPLATE...DONE
info: Missing directory ./app/scripts. COPYING from TEMPLATE...DONE
info: Missing file ./app/next.config.js. COPYING from TEMPLATE...DONE
info: Missing file ./app/next-env.d.ts. COPYING from TEMPLATE...DONE
info: Missing directory ./app/src/pages. COPYING from TEMPLATE...DONE
info: Missing file ./app/Gemfile. COPYING from TEMPLATE...DONE
info: Missing file ./app/metro.config.js. COPYING from TEMPLATE...DONE
info: Missing file ./app/react-native.config.js. COPYING from TEMPLATE...DONE
info: .rnv/schemas folder missing. CREATING...DONE
info: Updating appConfig app with title: app and id: com.mycompany.app
✔ Executing: yarn add @rnv/engine-rn-next@1.7.0-rc.0 --dev
✔ Executing: yarn add @rnv/engine-rn@1.7.0-rc.0 --dev
✔ Executing: yarn
task: ✔ new
┌─────────────────────────────────────────────────────────────────┐
│ ⚠ SUMMARY | 27/11/2024, 11:23:03 | rnv@1.7.0-rc.0 │
│ $ rnv new --projectName app --workspace appgyver --title app --id com.mycompany.app --appVersion 0.1.0 --local-template-path /Users/pauliusguzas/Desktop/renative/renative/packages/template-starter --ci --yes
├─────────────────────────────────────────────────────────────────┤
│ Project: app@0.1.0 │
│ Workspace: appgyver │
│ Engine: @rnv/engine-core │
│ Template: @rnv/template-starter │
│ Build Scheme (-s): debug │
│ Env Info: darwin | x64 | node v18.18.0 │
│ Executed Time: 0h:0m:44s:933ms │
│ warn: Folder ./app already exists. RNV will override it.
│
Generated Project Summary:
-------------------------
Project Name (--projectName): app
Package name: app
Project Version (--appVersion): 0.1.0
Workspace (--workspace): appgyver
App Title (--title): app
App ID (--id): com.mycompany.app
Project Template (--template): ./renative/renative/packages/template-starter
Git Enabled (--gitEnabled): false
Enabled Platforms: web, ios, android
-------------------------
✔ Your project is ready! Run it with:
cd app
npx rnv run
└─────────────────────────────────────────────────────────────────┘
pauliusguzas@MBP-de-Flexn Desktop % cd app
Unknown ruby interpreter version (do not know how to handle): >=2.6.10.
pauliusguzas@MBP-de-Flexn app % npx rnv run -p web
┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗ ██╗ █████╗ ████████╗██╗██╗ ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗ ██║██╔══██╗╚══██╔══╝██║██║ ██║██╔════╝ │
│ ██████╔╝█████╗ ██╔██╗ ██║███████║ ██║ ██║██║ ██║█████╗ │
│ ██╔══██╗██╔══╝ ██║╚██╗██║██╔══██║ ██║ ██║╚██╗ ██╔╝██╔══╝ │
│ ██║ ██║███████╗██║ ╚████║██║ ██║ ██║ ██║ ╚████╔╝ ███████╗ │
│ ╚═╝ ╚═╝╚══════╝╚═╝ ╚═══╝╚═╝ ╚═╝ ╚═╝ ╚═╝ ╚═══╝ ╚══════╝ │
│ $ npx rnv run -p web │
└─────────────────────────────────────────────────────────────────┘
error: ⨯ Platform web is not supported!
error: ⨯ Platform web is not supported!
┌─────────────────────────────────────────────────────────────────┐
│ ⨯ SUMMARY | 27/11/2024, 11:24:09 | rnv@ │
│ $ npx rnv run -p web │
├─────────────────────────────────────────────────────────────────┤
│ Project: app@0.1.0 │
│ Workspace: appgyver │
│ Platform (-p): web │
│ Template: @rnv/template-starter │
│ Build Scheme (-s): debug │
│ Env Info: darwin | x64 | node v18.18.0 │
│ Executed Time: 0h:0m:0s:203ms │
│ error: ⨯ Platform web is not supported!
└─────────────────────────────────────────────────────────────────┘
pauliusguzas@MBP-de-Flexn app %
locksten
approved these changes
Nov 27, 2024
pauliusguzas
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
it seems like if a template doesn't list any platform-specific paths, rnv assumes that it does not support that platform at all. That breaks some existing templates.
Related issues
Npm releases
n/a