Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/supportedPlatforms_detection #1801

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

ElenaDiachenko
Copy link
Contributor

Description

  • rnv doesn’t detect supported platforms properly:
    it seems like if a template doesn't list any platform-specific paths, rnv assumes that it does not support that platform at all. That breaks some existing templates.

Related issues

  • GH issues

Npm releases

n/a

@ElenaDiachenko ElenaDiachenko added this to the 1.8 milestone Nov 26, 2024
@ElenaDiachenko ElenaDiachenko self-assigned this Nov 26, 2024
@Marius456 Marius456 added the e2e label Nov 26, 2024
@pauliusguzas pauliusguzas added e2e and removed e2e labels Nov 27, 2024
Copy link
Collaborator

@pauliusguzas pauliusguzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same bug not sorted

pauliusguzas@MBP-de-Flexn Desktop % npx rnv new --projectName app --workspace appgyver --title app --id com.mycompany.app --appVersion 0.1.0 --local-template-path ~/Desktop/renative/renative/packages/template-starter --ci --yes

┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝ │
│ ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗   │
│ ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝   │
│ ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗ │
│ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝ │
│ 🚀 v:1.7.0-rc.0 | renative.org | 27/11/2024, 11:22:18           │
│ $ rnv new --projectName app --workspace appgyver --title app --id com.mycompany.app --appVersion 0.1.0 --local-template-path /Users/pauliusguzas/Desktop/renative/renative/packages/template-starter --ci --yes
└─────────────────────────────────────────────────────────────────┘
info: Current engine: @rnv/engine-core (./renative/renative/packages/engine-core/lib)
task: ○ new ↺1
warn:  Folder ./app already exists. RNV will override it.
info: Cleaning up existing folder...
info: Found local template: @rnv/template-starter@1.7.0-rc.0
✔ Executing: yarn
✔ Executing: yarn add @rnv/config-templates@1.7.0-rc.0 --dev
info: Missing directory ./app/buildHooks. COPYING from TEMPLATE...DONE
info: Missing directory ./app/src/app. COPYING from TEMPLATE...DONE
info: Missing directory ./app/src/entry. COPYING from TEMPLATE...DONE
info: Missing file ./app/src/config.tsx. COPYING from TEMPLATE...DONE
info: Missing file ./app/index.js. COPYING from TEMPLATE...DONE
info: Missing file ./app/tsconfig.json. COPYING from TEMPLATE...DONE
info: Missing file ./app/babel.config.js. COPYING from TEMPLATE...DONE
info: Missing directory ./app/typings. COPYING from TEMPLATE...DONE
info: Missing file ./app/.gitignore. COPYING from TEMPLATE...DONE
info: Missing directory ./app/appConfigs/app. COPYING from TEMPLATE...DONE
info: Missing directory ./app/appConfigs/base/assets. COPYING from TEMPLATE...DONE
info: Missing directory ./app/appConfigs/base/fonts. COPYING from TEMPLATE...DONE
info: Missing directory ./app/scripts. COPYING from TEMPLATE...DONE
info: Missing file ./app/next.config.js. COPYING from TEMPLATE...DONE
info: Missing file ./app/next-env.d.ts. COPYING from TEMPLATE...DONE
info: Missing directory ./app/src/pages. COPYING from TEMPLATE...DONE
info: Missing file ./app/Gemfile. COPYING from TEMPLATE...DONE
info: Missing file ./app/metro.config.js. COPYING from TEMPLATE...DONE
info: Missing file ./app/react-native.config.js. COPYING from TEMPLATE...DONE
info: .rnv/schemas folder missing. CREATING...DONE
info: Updating appConfig app with title: app and id: com.mycompany.app
✔ Executing: yarn add @rnv/engine-rn-next@1.7.0-rc.0 --dev
✔ Executing: yarn add @rnv/engine-rn@1.7.0-rc.0 --dev
✔ Executing: yarn
task: ✔ new
┌─────────────────────────────────────────────────────────────────┐
│ ⚠ SUMMARY | 27/11/2024, 11:23:03 | rnv@1.7.0-rc.0               │
│ $ rnv new --projectName app --workspace appgyver --title app --id com.mycompany.app --appVersion 0.1.0 --local-template-path /Users/pauliusguzas/Desktop/renative/renative/packages/template-starter --ci --yes
├─────────────────────────────────────────────────────────────────┤
│ Project: app@0.1.0                                              │
│ Workspace: appgyver                                             │
│ Engine: @rnv/engine-core                                        │
│ Template: @rnv/template-starter                                 │
│ Build Scheme (-s): debug                                        │
│ Env Info: darwin | x64 | node v18.18.0                          │
│ Executed Time: 0h:0m:44s:933ms                                  │
│ warn:  Folder ./app already exists. RNV will override it.
│
  Generated Project Summary:
  -------------------------
  Project Name (--projectName): app
  Package name: app
  Project Version (--appVersion): 0.1.0
  Workspace (--workspace): appgyver
  App Title (--title): app
  App ID (--id): com.mycompany.app
  Project Template (--template): ./renative/renative/packages/template-starter
  Git Enabled (--gitEnabled): false
  Enabled Platforms: web, ios, android
  -------------------------
  ✔ Your project is ready! Run it with:

  cd app
  npx rnv run
└─────────────────────────────────────────────────────────────────┘
pauliusguzas@MBP-de-Flexn Desktop % cd app
Unknown ruby interpreter version (do not know how to handle): >=2.6.10.
pauliusguzas@MBP-de-Flexn app % npx rnv run -p web

┌─────────────────────────────────────────────────────────────────┐
│ ██████╗ ███████╗███╗   ██╗ █████╗ ████████╗██╗██╗   ██╗███████╗ │
│ ██╔══██╗██╔════╝████╗  ██║██╔══██╗╚══██╔══╝██║██║   ██║██╔════╝ │
│ ██████╔╝█████╗  ██╔██╗ ██║███████║   ██║   ██║██║   ██║█████╗   │
│ ██╔══██╗██╔══╝  ██║╚██╗██║██╔══██║   ██║   ██║╚██╗ ██╔╝██╔══╝   │
│ ██║  ██║███████╗██║ ╚████║██║  ██║   ██║   ██║ ╚████╔╝ ███████╗ │
│ ╚═╝  ╚═╝╚══════╝╚═╝  ╚═══╝╚═╝  ╚═╝   ╚═╝   ╚═╝  ╚═══╝  ╚══════╝ │
│ $ npx rnv run -p web                                            │
└─────────────────────────────────────────────────────────────────┘
error: ⨯  Platform web is not supported!
error: ⨯  Platform web is not supported!
┌─────────────────────────────────────────────────────────────────┐
│ ⨯ SUMMARY | 27/11/2024, 11:24:09 | rnv@                         │
│ $ npx rnv run -p web                                            │
├─────────────────────────────────────────────────────────────────┤
│ Project: app@0.1.0                                              │
│ Workspace: appgyver                                             │
│ Platform (-p): web                                              │
│ Template: @rnv/template-starter                                 │
│ Build Scheme (-s): debug                                        │
│ Env Info: darwin | x64 | node v18.18.0                          │
│ Executed Time: 0h:0m:0s:203ms                                   │
│ error: ⨯  Platform web is not supported!
└─────────────────────────────────────────────────────────────────┘
pauliusguzas@MBP-de-Flexn app %

@pauliusguzas pauliusguzas self-requested a review November 27, 2024 13:21
@pauliusguzas pauliusguzas merged commit b56e8a6 into main Nov 27, 2024
12 of 13 checks passed
@pauliusguzas pauliusguzas deleted the fix/supportedPlatforms_detection branch November 27, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants