Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing main.jsbundle and assets when build tvos #1811

Merged
merged 1 commit into from
Dec 3, 2024
Merged

add missing main.jsbundle and assets when build tvos #1811

merged 1 commit into from
Dec 3, 2024

Conversation

ElenaDiachenko
Copy link
Contributor

@ElenaDiachenko ElenaDiachenko commented Nov 30, 2024 •
edited
Loading

Description

  • main.jsbundle and assets folder missing when build tvos

Related issues

Npm releases

n/a

Testing

  • run npx rnv build -p tvos -s release
  • open project in xcode and check Build Phases / Copy Bundle Resources => main.jsbundle and assets are present
xcode
  • run using xcode => success

@ElenaDiachenko ElenaDiachenko added this to the 1.8 milestone Nov 30, 2024
@ElenaDiachenko ElenaDiachenko self-assigned this Dec 2, 2024
@pauliusguzas pauliusguzas self-requested a review December 2, 2024 14:10
@kasinskas kasinskas merged commit 06a0765 into main Dec 3, 2024
12 of 13 checks passed
@kasinskas kasinskas deleted the fix/tvos_build branch December 3, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauliusguzas pauliusguzas pauliusguzas approved these changes

@kasinskas kasinskas kasinskas approved these changes

Assignees

@ElenaDiachenko ElenaDiachenko

Labels
e2e
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@ElenaDiachenko @kasinskas @pauliusguzas