Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose public funcs #3

Merged
merged 4 commits into from
May 17, 2024
Merged

Expose public funcs #3

merged 4 commits into from
May 17, 2024

Conversation

nathreed
Copy link
Contributor

  • Expose some tile util functions as public
  • Tweaks to mbtiles CreateMetadata to remove hardcoded format and enable re-use for creating raster metadata json

@nathreed nathreed requested a review from polastre May 17, 2024 13:34
polastre
polastre approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@polastre polastre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor golang convention change requested, then looks great. Thanks for doing this to make these functions usable as an imported package.

mbtiles.go Outdated Show resolved Hide resolved
@nathreed nathreed merged commit 2bca1ba into main May 17, 2024
1 check passed
@nathreed nathreed deleted the expose-public-funcs branch May 17, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polastre polastre polastre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathreed @polastre