Only check for ambiguous classes in development (#107)

flightcontrolhq · Feb 2, 2021 · 8e91154 · 8e91154
1 parent efbacad
commit 8e91154
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/registry.test.ts b/src/registry.test.ts
@@ -16,8 +16,11 @@ test('class registry', () => {
 
   expect(() => registry.register(Car)).not.toThrow();
 
-  expect(() => registry.register(class Car {})).toThrow(
-    'Ambiguous class, provide a unique identifier.'
+  const warnSpy = jest.spyOn(console, 'warn');
+
+  registry.register(class Car {});
+  expect(warnSpy).toHaveBeenCalledWith(
+    'Ambiguous class "Car", provide a unique identifier.'
   );
 
   registry.register(class Car {}, 'car2');

diff --git a/src/registry.ts b/src/registry.ts
@@ -14,8 +14,13 @@ export class Registry<T> {
       identifier = this.generateIdentifier(value);
     }
 
-    if (this.kv.getByKey(identifier)) {
-      throw new Error('Ambiguous class, provide a unique identifier.');
+    if (process.env.NODE_ENV !== 'production') {
+      const alreadyRegistered = this.kv.getByKey(identifier);
+      if (alreadyRegistered && alreadyRegistered !== value) {
+        console.warn(
+          `Ambiguous class "${identifier}", provide a unique identifier.`
+        );
+      }
     }
 
     this.kv.set(identifier, value);