Fix #62 (Again) (#110)

* Also Test on Pre-ES6 Node

* Use ES5-Compatible alternative of "fromEntries"

* Skip symbol-related tests on v10

* Use jest's skip instead

.github/workflows/main.yml

@@ -4,14 +4,22 @@ jobs:
  build:
  runs-on: ubuntu-latest
 
+ strategy:
+ matrix:
+ node: [14.x, 12.x, 10.x]
+
+ env:
+ CI: true
+ YARN_IGNORE_ENGINES: true
+
  steps:
  - name: Begin CI...
  uses: actions/checkout@v2
 
- - name: Use Node 12
+ - name: Use Node
  uses: actions/setup-node@v1
  with:
- node-version: 12.x
+ node-version: ${{ matrix.node }}
 
  - name: Use cached node_modules
  uses: actions/cache@v2
@@ -23,28 +31,19 @@ jobs:
 
  - name: Install dependencies
  run: yarn install --frozen-lockfile
- env:
- CI: true
 
  - name: Lint
  run: yarn lint
- env:
- CI: true
 
  - name: Test
  run: yarn test --ci --coverage --maxWorkers=2
- env:
- CI: true
 
  - name: Build
  run: yarn build
- env:
- CI: true
 
  - name: Run benchmark
  run: node benchmark.js | tee output.txt
  env:
- CI: true
  NODE_ENV: production
 
  - name: Store benchmark result

src/index.test.ts

@@ -8,6 +8,8 @@ import { isArray, isMap, isPlainObject, isPrimitive, isSet } from './is';
 
 import { ObjectID } from 'mongodb';
 
+const isNode10 = process.version.indexOf('v10') === 0;
+
 describe('stringify & parse', () => {
  const cases: Record<
  string,
@@ -16,6 +18,7 @@ describe('stringify & parse', () => {
  output: JSONValue | ((v: JSONValue) => void);
  outputAnnotations?: Annotations;
  customExpectations?: (value: any) => void;
+ skipOnNode10?: boolean;
  dontExpectEquality?: boolean;
  }
  > = {
@@ -424,6 +427,7 @@ describe('stringify & parse', () => {
  },
 
  'works for symbols': {
+ skipOnNode10: true,
  input: () => {
  const parent = Symbol('Parent');
  const child = Symbol('Child');
@@ -473,6 +477,7 @@ describe('stringify & parse', () => {
  },
 
  'issue #58': {
+ skipOnNode10: true,
  input: () => {
  const cool = Symbol('cool');
  SuperJSON.registerSymbol(cool);
@@ -580,10 +585,17 @@ describe('stringify & parse', () => {
  output: expectedOutput,
  outputAnnotations: expectedOutputAnnotations,
  customExpectations,
+ skipOnNode10,
  dontExpectEquality,
  },
  ] of Object.entries(cases)) {
- test(testName, () => {
+ let testFunc = test;
+
+ if (skipOnNode10 && isNode10) {
+ testFunc = test.skip;
+ }
+
+ testFunc(testName, () => {
  const inputValue = typeof input === 'function' ? input() : input;
 
  // let's make sure SuperJSON doesn't mutate our input!

src/transformer.ts

@@ -304,9 +304,10 @@ export const transformValue = (
  return undefined;
 };
 
-const simpleRulesByAnnotation = Object.fromEntries(
- simpleRules.map(r => [r.annotation, r])
-);
+const simpleRulesByAnnotation: Record<string, typeof simpleRules[0]> = {};
+simpleRules.forEach(rule => {
+ simpleRulesByAnnotation[rule.annotation] = rule;
+});
 
 export const untransformValue = (json: any, type: TypeAnnotation) => {
  if (isArray(type)) {