Rewrite "Plainer", remove a whole lot of code. #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! I didn't look closely, but sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rather sizeable refactoring. It changes the
plainerto recursively build the Annotation tree, removing the need for unneccessary tree traversals (looking atPathTree#appendandannotator.ts).It simplifies the inner workings of SuperJSON by large.
To fully remove
PathTree, I had to change the representation ofreferentialEquality. This is not a breaking change, since SuperJSON's output is not considered a public API - but if you depend on it nonetheless, watch out.It also removes the schema checks that where performed during deserialisation. I consider them unneccessary overhead.