Define empty state if initialState function not called #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this.state, by definiton, is an object of key/values. It should never be undefined. If no state has been set yet, this.state should be an empty object.
tgvashworth
added a commit
that referenced
this pull request
Jul 20, 2015
Define empty state if initialState function not called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.state, by definiton, is an object of key/values. It should
never be undefined. If no state has been set yet, this.state should
be an empty object.
NB: This is useful, because in with-observable-state we kinda need an initial state, otherwise we're pushing undefined values down the stream, and subscribers have to handle these individually. Another option is to make initialState a required call.