gpu_fdinfo: add vram usage (amd, intel) and power usage via hwmon (only intel) #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when printing stats while debugging, it spams the stdout, also why bother checking so frequently if gui updates every 500ms?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested that vram usage works both on my machine (intel arc a770) and on my laptop with integrated raven2 amd gpu (with changing a line to fdinfo here). Qualcomm have not implemented vram usage via fdinfo, so no vram for msm for now :).
One thing which I'm concerned about is that power usage might not work on older intel integrated gpus. The only test subject that I have is an i5-2500M and it doesn't have any gpu sensors.