Add a SSE2 fast path for AMD GPU #827
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves memory because of the differnce in structure padding. As a side effect storage of unused fields has been removed from this to save more time and effort.
|
I can see moving from AOS to SOA making a difference, but. Does the SSE2 stuff actually make any difference? I am guessing not? Compilers are good at vectorizing in $CURRENT_YEAR (pls provide numbers + compile flags you used) |
mupuf
reviewed
Aug 24, 2022
| uint16_t soc_temp_c; | ||
| uint16_t gpu_temp_c; | ||
| uint16_t apu_cpu_temp_c; | ||
| #ifdef AMG_GPU_TEMP_MONITORING |
Comment on lines
+62
to
+76
| # Check for SSE2 | ||
| if cc.compiles('''#include <emmintrin.h> | ||
| int main() { | ||
| __m128 v1 = _mm_set1_ps(-1.0f); | ||
| __m128 v2 = _mm_set1_ps(1.0f); | ||
| v1 = _mm_add_ps(v1, v2); | ||
| float sum[4]; | ||
| _mm_store_ps(sum, v1); | ||
| return (int)sum[0]; | ||
| }''', | ||
| name : 'SSE2 support', | ||
| args : '-msse2') | ||
| pre_args += '-DUSE_SSE2' | ||
| pre_args += '-msse2' | ||
| endif |
There was a problem hiding this comment.
Maybe use the SIMD module?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a couple of things:
memcpying it. This saves us from some handling of fields that aren't actually exported, and is a bit less future maintenance.Open questions with this work: