Added ability to load classes with _ in them #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0nag0n
commented
Mar 30, 2024
There was a problem hiding this comment.
This actually caused php8.1+ to fail because it thought the ReturnTypeWillChange class was an attribute class....so it failed.
n0nag0n
commented
Mar 30, 2024
| $this->expectException(ErrorException::class); | ||
| $this->expectExceptionMessageMatches("/Passing null to parameter/"); | ||
| // php 7.4 will throw a PDO exception, but php 8 will throw an ErrorException | ||
| if(version_compare(PHP_VERSION, '8.0.0', '<')) { |
There was a problem hiding this comment.
This is highly unusual, but the behavior in PDO actually changed inbetween 7.4 and 8.0 to throw different error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to load a class in your codebase such as
Pascal_Snake_Caseand it will still work. You must set it withLoader::setV2ClassLoading(false);