Fix content length when using response body callbacks #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to give my changes a go real quick to make sure I didn't mess up anything on your end? |
Still works as expected on my end, thanks for checking |
n0nag0n
approved these changes
Apr 11, 2024
|
Merged and released as v3.8.1. Thanks for the assist! |
|
Thanks for getting this merged and releasing the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#571 introduced an issue where the response body could be modified after Flight calculates & sends the content length to the browser. Since the response body callback modifies the body, the content length is no longer correct.
In my testing things seemed to still work okay locally with the PHP dev server, but once I moved to an actual server I noticed the browser would sit and continue to try to load after the body has already sent as the response body was compressed after the content length was sent.
Switching the order so the callback is called and then headers are sent fixes this