Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed for middlewares to be created with container #585

Merged
merged 1 commit into from
May 9, 2024
Merged

Allowed for middlewares to be created with container #585

merged 1 commit into from
May 9, 2024

Conversation

n0nag0n
Copy link
Collaborator

@n0nag0n n0nag0n commented May 2, 2024

This PR allows for middlewares to be called with just class names Middleware::class for use with and without a container handler.

@n0nag0n n0nag0n mentioned this pull request May 2, 2024
Closed
@n0nag0n n0nag0n merged commit c3c5c29 into master May 9, 2024
@n0nag0n n0nag0n deleted the middleware-use-container branch May 9, 2024 04:23
fadrian06
fadrian06 reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@fadrian06 fadrian06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on improving the integration with the container.

Just a suggestion, I had a hard time reading the diff between the change from snake to camelCase, so it's okay to separate it into 2 commits that are free :D

@n0nag0n
Copy link
Collaborator Author

n0nag0n commented May 9, 2024

Ahh yeah.....I could have, but it was just bugging the crap out of me so I did it in the one commit haha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadrian06 fadrian06 fadrian06 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n0nag0n @fadrian06