Allow Symfony 4 #31
Open
Allow Symfony 4 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciaranmcnulty
force-pushed
the
specific-phpunit-version
branch
from
61b9b85
to
26edde6
Compare
ciaranmcnulty
force-pushed
the
specific-phpunit-version
branch
from
26edde6
to
3c67815
Compare
|
Could try to look at the inotify failures if there is a chance of having this merged. @henrikbjorn , do you still maintain this repo? If not, could you please ask for additional maintainers? |
|
@danmichaelo please see #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowed Symfony 4, had to:
There are still inotify failures, I suspect related to more breaking changes in Symfony/FileResource, but I don't have time to reproduce locally right now; perhaps someone else can pick this up