Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix add_ssssaaaaaaaa fallback #558

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

tthsqe12
Copy link
Contributor

this was another of those "compiler bugs" :-)
On a serious note, the 64 bit windows box in spot #1 on @isuruf 's appveyor seems to NOT be using our lovely hand-crafted asm macros in longlong.h. This is an outrage as much of flint's speed on small operands derives from these macros.

@tthsqe12
Copy link
Contributor Author

Here is an example of the problem caused by mp_bitcnt_t
https://github.com/wbhart/flint2/blob/trunk/fmpz_factor/factor_trial_range.c#L59
On 64bit windows with gcc (machine #3 on @isuruf 's appveyor), the mp_bitcnt_t is long unsigned int and the mp_limb_t is long long unsigned int

@tthsqe12
Copy link
Contributor Author

machine #3 on @isuruf 's appveyor is completely broken.

@wbhart wbhart merged commit a03d4d3 into flintlib:trunk Apr 26, 2019
@isuruf
Copy link
Member

isuruf commented Apr 26, 2019

@tthsqe12, it worked in #548. Some PR must have broken it.

@isuruf
Copy link
Member

isuruf commented Apr 26, 2019

euler_phi....
This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.
Exception (flint_mpz_pow_ui). Power too large

is an overflow issue.

@tthsqe12
Copy link
Contributor Author

See #557 for why it is broken now. Once you have an undefined pointer cast like the one I cited above, anything can happen.

@tthsqe12
Copy link
Contributor Author

I am strongly in favour of increasing our testing regimen.

@isuruf
Copy link
Member

isuruf commented Apr 28, 2019

I am strongly in favour of increasing our testing regimen.

Me too. We can enable appveyor on this repo again. I can also add cygwin tests if needed. MinGW and MSVC tests are already there.

@tthsqe12 tthsqe12 deleted the fix_asm_macro_fallback branch July 14, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants