Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use slong instead of long for arb accuracy #37

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

oscarbenjamin
Copy link
Collaborator

Fixes #32

Fixes a bug seen under Windows where 32 bit long caused showgood to fail. There are more places where long should be changed to slong but this change is enough to get the full test suite (including doctests) to pass on Windows according to my local testing.

Fixes a bug seen under Windows where 32 bit long caused showgood to fail.
There are more places where long should be changed to slong but this
change is enough to get the full test suite to pass on Windows
@oscarbenjamin
Copy link
Collaborator Author

Okay, all tests passed for Windows in CI. I'll merge this for now.

I'll be happier to make a wholesale long -> slong transformation when the test coverage is higher.

@oscarbenjamin oscarbenjamin merged commit d6e239d into flintlib:master Dec 14, 2022
@oscarbenjamin oscarbenjamin deleted the pr_slong2 branch December 14, 2022 18:38
@fredrik-johansson
Copy link
Collaborator

I'll be happier to make a wholesale long -> slong transformation when the test coverage is higher.

I don't think there is any place where long is meant to be used, so no need to be extremely conservative about this.

@oscarbenjamin
Copy link
Collaborator Author

oscarbenjamin commented Dec 14, 2022

I don't think there is any place where long is meant to be used, so no need to be extremely conservative about this.

I realise that but any change is a change and sometimes fixing one bug can cause a new bug because previous bugs cancelled out etc. We're getting close to having dependable CI with cross platform testing which will make me a lot happier to mess around with internals. Once you're at the point where things are known tested and working and you can see that any problem is caused by an identifiable new change everything gets a lot easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows support (again)
2 participants