Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModuleVersion trimmed #131

Merged
merged 1 commit into from
May 29, 2018
Merged

ModuleVersion trimmed #131

merged 1 commit into from
May 29, 2018

Conversation

birat-flipkart
Copy link
Contributor

  • removing newline from end of string, which were causing the NumberFormatException while parsting the patch version of module.

@pmohankumar pmohankumar self-requested a review May 29, 2018 05:10
pmohankumar
pmohankumar reviewed May 29, 2018
View reviewed changes
service-clients-gen/src/main/java/com/flipkart/poseidon/serviceclients/generator/Generator.java
@@ -102,6 +102,7 @@ private static void determineVersion(String localPomVersion) {
}

private static void setVersion(String moduleVersion) {
moduleVersion = moduleVersion.trim();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trim removes just space, but version itself is taken as a command line argument separated by space, hence version here won't have space. Are you sure this fixes the bug?

Copy link
Contributor Author

@birat-flipkart birat-flipkart May 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String.trim() removes whitespaces (spaces, new lines etc.), here moduleVersion is coming like "1.0.0\n" or "1.0.0-SNAPSHOT\n" hence trim solves the problem.

@pmohankumar
Copy link
Contributor

Fixes issue #130

@pmohankumar pmohankumar merged commit 97bc2f9 into flipkart-incubator:master May 29, 2018
@pmohankumar
Copy link
Contributor

Thanks @birat-flipkart. @shrey-garg , can you deploy this version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmohankumar pmohankumar pmohankumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birat-flipkart @pmohankumar