Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis 4.6.0 spits warnings in puma.log #608

Closed
gingerlime opened this issue Feb 10, 2022 · 4 comments
Closed

redis 4.6.0 spits warnings in puma.log #608

gingerlime opened this issue Feb 10, 2022 · 4 comments

Comments

@gingerlime
Copy link

gingerlime commented Feb 10, 2022

we're seeing these in our puma logs after upgrading the redis gem to 4.6.0

[2102591] + Gemfile in context: /var/local/app/app.d/110/Gemfile
Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.pipelined do
  redis.get("key")
end

should be replaced by

redis.pipelined do |pipeline|
  pipeline.get("key")
end

(called from /var/local/app/app.d/110/vendor/bundle/ruby/3.0.0/gems/flipper-redis-0.23.1/lib/flipper/adapters/redis.rb:133:in `docs_for'}
@gingerlime
Copy link
Author

it seems like this was recently fixed in sidekiq for example

@jnunemaker
Copy link
Collaborator

This is fixed just not released yet. Should be soon.

#603

@gingerlime
Copy link
Author

Great! Thank you!!

@amysahli
Copy link

Looking forward to the release @jnunemaker . Thanks for all your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants