Fix deprecated uses of Redis#pipelined
#603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeepers
reviewed
Jan 25, 2022
lib/flipper/adapters/redis.rb
Outdated
| @@ -125,14 +125,14 @@ def read_feature_keys | |||
| # Private: Gets a hash of fields => values for the given feature. | |||
| # | |||
| # Returns a Hash of fields => values. | |||
| def doc_for(feature) | |||
| def doc_for(feature, _pipeline: @client) | |||
| @client.hgetall(feature.key) | |||
There was a problem hiding this comment.
Should this use _pipeline?
There was a problem hiding this comment.
Fixed. Also since I noticed the doc mark the method as private, I droped the leading _.
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference. This API is available since Redis 3.0.
casperisfine
force-pushed
the
redis-4.6-compat
branch
from
9f61bcb
to
c508eb5
Compare
|
Is there an ETA for this to be released? I hate to put github deps in Gem file. Thanks. |
|
Personally, I don't mind locking to a ref for a bit, but I just released 0.24.0 for you. :) |
|
Thank you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: redis/redis-rb#1059
The following is deprecated
And should be rewritten as:
Functionally it makes no difference.
This API is available since Redis 3.0.