-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Redis#queue
, Redis#commit
and Redis#pipelined
without block.
#1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
pipeline-deprecation-2
branch
from
January 20, 2022 11:32
49383bd
to
57f5053
Compare
… block. All theses make a lot of assumptions on the threading model and are barely thread safe. The new favored API is: ```ruby redis.pipelined do |pipeline| pipeline.get("foo") pipeline.del("bar") end ``` This API allow multiple threads to build pipelines concurrently on the same connection, and is more friendly to Fiber based concurrency. Fix: redis#1057
casperisfine
force-pushed
the
pipeline-deprecation-2
branch
from
January 20, 2022 13:01
57f5053
to
0f86bac
Compare
This was referenced Jan 21, 2022
casperisfine
pushed a commit
to casperisfine/progressrus
that referenced
this pull request
Jan 24, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference.
casperisfine
pushed a commit
to casperisfine/sidekiq
that referenced
this pull request
Jan 24, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference.
casperisfine
pushed a commit
to casperisfine/sidekiq
that referenced
this pull request
Jan 24, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference.
mperham
pushed a commit
to sidekiq/sidekiq
that referenced
this pull request
Jan 24, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference. Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
casperisfine
pushed a commit
to casperisfine/redis-store
that referenced
this pull request
Jan 24, 2022
The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference.
casperisfine
pushed a commit
to casperisfine/redis-store
that referenced
this pull request
Jan 24, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference.
casperisfine
pushed a commit
to Shopify/rack-mini-profiler
that referenced
this pull request
Jan 25, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference.
casperisfine
pushed a commit
to casperisfine/resque-scheduler
that referenced
this pull request
Jan 25, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference.
casperisfine
pushed a commit
to casperisfine/sidekiq-scheduler
that referenced
this pull request
Jan 25, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference.
casperisfine
pushed a commit
to casperisfine/flipper
that referenced
this pull request
Jan 25, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference. This API is available since Redis 3.0.
casperisfine
pushed a commit
to casperisfine/coverband
that referenced
this pull request
Jan 25, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference. This API is available since Redis 3.0.
casperisfine
pushed a commit
to casperisfine/stoplight
that referenced
this pull request
Jan 25, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference. This API is available since Redis 3.0.
casperisfine
pushed a commit
to casperisfine/flipper
that referenced
this pull request
Jan 25, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference. This API is available since Redis 3.0.
iloveitaly
pushed a commit
to resque/resque-scheduler
that referenced
this pull request
Jan 26, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference.
marcelolx
pushed a commit
to sidekiq-scheduler/sidekiq-scheduler
that referenced
this pull request
Jan 28, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference.
ixti
added a commit
to ixti/rack-attack
that referenced
this pull request
Feb 4, 2022
Redis 4.6.0 deprecated calling commands on `Redis` inside `#pipelined`: redis.pipelined do redis.get("key") end The above should be: redis.pipelined do |pipeline| pipeline.get("key") end See: redis/redis-rb#1059
OsamaSayegh
pushed a commit
to MiniProfiler/rack-mini-profiler
that referenced
this pull request
Feb 10, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference. Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
rsanheim
added a commit
to simpledotorg/simple-server
that referenced
this pull request
Feb 11, 2022
bolshakov
pushed a commit
to bolshakov/stoplight
that referenced
this pull request
Feb 23, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference. This API is available since Redis 3.0. Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
This was referenced Mar 4, 2022
In which version this “favored API” with block param was introduced?
This is required to properly constrain redis gem versions in dependent gems and applications. Thanks. |
In |
marcelolx
pushed a commit
to sidekiq-scheduler/sidekiq-scheduler
that referenced
this pull request
Mar 21, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference.
johnsyweb
added a commit
to johnsyweb/fresh_redis
that referenced
this pull request
Apr 29, 2022
The version without the block causes exccessive logging since redis/redis-rb#1059
Hi, |
nevans
added a commit
to nevans/resque
that referenced
this pull request
Jun 21, 2022
Re-using the connection is no longer supported. Instead, the block var must be used. See also: * redis/redis-rb#1059 * resque/redis-namespace#192
iloveitaly
pushed a commit
to resque/resque
that referenced
this pull request
Jun 22, 2022
Re-using the connection is no longer supported. Instead, the block var must be used. See also: * redis/redis-rb#1059 * resque/redis-namespace#192
jwoodrow
pushed a commit
to moonproject/resque
that referenced
this pull request
Aug 5, 2022
Re-using the connection is no longer supported. Instead, the block var must be used. See also: * redis/redis-rb#1059 * resque/redis-namespace#192
dalpo
added a commit
to dalpo/sidekiq-scheduler
that referenced
this pull request
Dec 19, 2022
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference. Original commit: sidekiq-scheduler@041d2b5
jlledom
added a commit
to jlledom/apisonator
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All theses make a lot of assumptions on the threading model and are barely thread safe.
The new favored API is:
This API allow multiple threads to build pipelines concurrently on the same connection, and is more friendly to Fiber based concurrency.
Fix: #1057
The same should be applied to
Redis#multi
, and we might want to add an easy way to turn off deprecation warnings.FYI: @machty