-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Strict adapter to ensure feature exists on get #760
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left a couple questions. I'd think get_multi should be in so there is a raise/warning for preloading the wrong feature name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you envisioning that this would be used like in the example or would it also have some level of configuration? i.e. Is the configuration happening purely from how the initializer is called?
Still in progress, but this is what I am imagining: #763 |
First pass at adding a strict adapter to ensure only features that exist can be called.
In a follow up PR I'm hoping to use this by default in Rails apps in development/test.