Hide UI elements when Flipper is in read-only mode #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! I'll try to review/merge soon but wanted you to know I appreciate the contribution! |
|
Thanks for making the Flipper code so easy to read and reason about. It was a pleasure to contribute :) |
jnunemaker
reviewed
Nov 17, 2023
| @@ -23,7 +23,7 @@ def get | |||
| end | |||
|
|
|||
| def post | |||
| read_only if Flipper::UI.configuration.read_only | |||
| read_only if read_only? | |||
There was a problem hiding this comment.
Should this be render_read_only also?
lib/flipper/ui/views/features.erb
Outdated
| @@ -3,15 +3,16 @@ | |||
| <% if Flipper::UI.configuration.fun %> | |||
| <h4>But I've got a blank space baby...</h4> | |||
| <p>And I'll flip your features.</p> | |||
| <%- if !Flipper::UI.configuration.read_only && Flipper::UI.configuration.feature_creation_enabled -%> | |||
| <%= read_only? %> | |||
There was a problem hiding this comment.
Did you mean to leave this?
radar
force-pushed
the
hide-ui-elements-in-read-only-mode
branch
from
8fe8574 to
15283bc
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a particular business-critical application that uses Flipper flags, and we would like to provide a completely read-only UI with Flipper. I know of a way to do this, which is to set
Flipper::UI's configuration to be read only. However, this same application is a bit a "nexus" for some smaller apps, and therefore we have multiple instances ofFlipper::UIat play here. The different instances each control the flipper flags for the different applications.I was able to see that there's a
ReadOnlyadapter however:But this doesn't hide all the UI buttons in Flipper UI. Here's what I see in that app by default:
Having all the buttons and forms present makes our security people uncomfortable.
So what I've tried to do in this PR is to cut out all of the UI that performs a write action, which then cuts the page down to this:
And the homepage to this:
I've also updated the "nooooope" error screen to show that the
ReadOnlyadapter might be in use: