Cloud Telemetry #775
Merged
Cloud Telemetry #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increment is for tracking and drain is for when we submit to metrics collector.
* symbol headers avoids needing to freeze strings and makes consistency easier * schema version makes for nice ruby constants on the other end * array of metrics is easier to use dry-schema on server side to validate and inform of errors
…ifferent enabled state
* reset telemetry stuff in tests so they are always stopped * allow logging telemetry thread stuff but don't in specs * enforce minimum seconds around communication via polling or telemetry
its possible that the class could be defined but not the method if you are requiring say just metric class which defines classes but doesn't define reset for those classes.
This makes "true", "false", "1", "0" all work.
Because we only retry for like 2 minutes there is no point in trying to enqueue 30
Then I can get telemetry interval from errors too
Only takes one arg here so you have to do new to send more than one. Also extracted fake backoff to its own file so I can use it in other places.
Puts minimum enforcement in writer and now we can use this when updating config.
Had them separate on accident
Only call should be public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a fancy way to say this rolls up some metrics about your flags and ships them to cloud.