statsd cleanup #778
Merged
statsd cleanup #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks! Do you think we should warn or raise when the client is not set? I’m wondering if it would be confusing to have it fail silently. |
|
yeah, if someone explicitly plugs in the statsd subscriber but doesn't provide a client, failing loudly makes sense to me. I just didn't want to change the functionality on my first pass... we could also expose something in the config dsl that makes setup easier, eg. Flipper.configure do |conf|
conf.statsd = my_client
end |
jnunemaker
approved these changes
Dec 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was poking around and discovered the statsd subscriber. In addition to being excited to test it out in prod, I noticed a couple small improvements we might make to simplify - using the
&.operator to guard against nil objects, and adding test coverage... what'd you think?