Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Cloud secrets from Rails credentials #782

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Conversation

bkeepers
Copy link
Collaborator

@bkeepers bkeepers commented Dec 6, 2023

This allows setting Flipper Cloud secrets via Rails credentials

$ rails credentials:edit -e development
flipper:
  cloud_token: <your-cloud-token>
  cloud_sync_secret: <your-webhook-secret>

@bkeepers bkeepers requested a review from garrettdimon December 6, 2023 16:46
Copy link
Collaborator

@garrettdimon garrettdimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to have it proactively check credentials!

lib/flipper/engine.rb Show resolved Hide resolved
@jnunemaker
Copy link
Collaborator

Do app credentials already namespace by environment? Just curious.

@bkeepers
Copy link
Collaborator Author

bkeepers commented Dec 7, 2023

Do app credentials already namespace by environment? Just curious.

Yep! There are separate credentials files for each environment, e.g. rails credentials:edit -e test

@jnunemaker
Copy link
Collaborator

That's awesome.

@jnunemaker
Copy link
Collaborator

I guess the only issue would be how people get their personal environment configured? Or is that handled somehow too? Not a blocker at all just curious because I haven't used credentials.

@bkeepers
Copy link
Collaborator Author

bkeepers commented Dec 7, 2023

rails credentials:edit edits the development credentials. rails credentials:edit -e production edits the production credentials.

@bkeepers
Copy link
Collaborator Author

bkeepers commented Dec 7, 2023

rails credentials:edit edits the development credentials.

Correction, this edits the shared credentials. rails credentials:edit -e development edits the development credentials.

@bkeepers bkeepers merged commit 6979bc7 into main Dec 7, 2023
64 checks passed
@bkeepers bkeepers deleted the rails-credentials branch December 7, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants