Support Rack 3 #828
Merged
Support Rack 3 #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rack-protection was locking the rack version to 2x. Now that rack-protection 4 is out, we can update rack. rack-session has been extracted from rack, but has versions to work under rack 2 or 3.
danielmorrison
force-pushed
the
rack-protection-4
branch
from
9c5d3aa to
c766d5e
Compare
|
Requiring it has caused some issues in the past. I only use it for csrf. Not sure how that would work without requiring it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Rack 3.
Flipper UI's dependency on
rack-protectionwas locking therackversion to 2x. Now thatrack-protection4 is out, we can updaterack. This brings up a good question: should Flipper UI requirerack-protection? I like it and all, but might not be Flipper's responsibility. 🤷rack-sessionhas been extracted fromrack, but has versions to work under rack 2 or 3.I have a couple import-related tests failing locally, but haven't figured out exactly why yet. The
request.bodyisn't coming through (the body is aRackup::Handler::WEBrick::Inputand.rewindrails, but trying to.readreturns"").