Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor shared adapter test #854

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Refactor shared adapter test #854

merged 1 commit into from
Mar 2, 2024

Conversation

bkeepers
Copy link
Collaborator

@bkeepers bkeepers commented Mar 1, 2024

This refactors some of the adapter tests related to actors to use the feature interface instead of directly inspecting the adapters data. This change is needed for some work I'm doing to support large actor sets.

Copy link
Collaborator

@jnunemaker jnunemaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do the specs too? I try to keep them in sync with the shared tests.

@bkeepers bkeepers force-pushed the refactor-adapter-tests branch from a97842c to 04970d1 Compare March 2, 2024 12:47
@bkeepers bkeepers merged commit b59a7a9 into main Mar 2, 2024
72 checks passed
@bkeepers bkeepers deleted the refactor-adapter-tests branch March 2, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants