Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I²C-Scanner #1431

Closed
wants to merge 10 commits into from
Closed

I²C-Scanner #1431

wants to merge 10 commits into from

Conversation

GitChris3004
Copy link

@GitChris3004 GitChris3004 commented Jul 22, 2022 •
edited
Loading

What's new

  • adds I²C-Scanner which scans the I2C-Bus (SDA: Pin 15, SCL: Pin 16) for available 7-Bit slave addresses.
  • shows the number of detected slaves and their addresses (maximum of 8 addresses fit the screen).
    i2c_scanner

Verification

  • Connect one or multiple I²C components to the I²C-GPIOs of the Flipper (SDA: Pin 15, SCL: Pin 16, shared GND)
  • If your I²C-slave doesn't provide Pull-Up resistors you have to connect one 4k7 ohms resistor from SDA to 3V3 and one from SCL to 3V3
  • Go to "GPIO"->"I2C-Scanner" and press the "ok" button to start the scan.
  • The green LED will light up for half a second and after that the display will be updated with the number of slaves detected and their I²C-Addresses.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@xMasterX
Copy link
Contributor

Hi, you forgot to exclude that file from PR
assets/resources/Manifest

@GitChris3004
Copy link
Author

Hi, you forgot to exclude that file from PR assets/resources/Manifest

Hey, thx i reversed my changes.

@hedger hedger added UI Affects UI Applications Non-core applications New Feature Contains an IMPLEMENTATION of a new feature labels Jul 25, 2022
@skotopes
Copy link
Member

Hi. Scheduled for next release.

@GitChris3004
Copy link
Author

Hey, if there is anything i can do speeding up the merging process let me know.

@GitChris3004 GitChris3004 mentioned this pull request Aug 29, 2022
Closed
GitChris3004 and others added 2 commits August 30, 2022 13:09
@GitChris3004
Adaptions for making it work with updated branch.
589e62c 
ms_to_ticks function moved from <furi_hal_delay.h> to <furi.h>
@GitChris3004
Merge branch 'dev' into gpio_i2c_scanner
6d88912
@skotopes
Copy link
Member

Hi @GitChris3004

Sorry for delay, this PR is waiting for ELF support to be merged first.

@skotopes
Copy link
Member

@GitChris3004 we've merged ELF support. How about moving this feature to external application?

@wdoekes
Copy link
Contributor

wdoekes commented Sep 20, 2022

Cool. I planned on doing a Onewire scanner too. Just waiting for #1635. @skotopes: do you have feedback there?

@GitChris3004
Copy link
Author

@GitChris3004 we've merged ELF support. How about moving this feature to external application?

Hey, that's nice. I will have access to my flipper in about 2 weeks again. Then I can resolve the remaining merging conflicts. What do you mean with moving it to external application?

@skotopes
Copy link
Member

@GitChris3004 just change application type in .fam to the same value as in picopass app.

@skotopes skotopes closed this Oct 8, 2022
@skotopes
Copy link
Member

skotopes commented Oct 8, 2022

We can accept it as external application. Meanwhile I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov

Assignees
No one assigned
Labels
Applications Non-core applications New Feature Contains an IMPLEMENTATION of a new feature UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GitChris3004 @xMasterX @skotopes @wdoekes @hedger