Add skylanders (/activision) mifare classic to identification procedure

[equipter]

adds Skylanders SAK and ATQA to identification proc

used ATQA1 as necessary (previously marked as unused for Mifare classic)
added ATQA0 == 0x0F ATQA1 == 0x01 SAK == 0x01 for identification proc

Verification

scan a Skylanders or infinity figurine using NFC

Checklist (For Reviewer)

• PR has description of feature/bug or link to Confluence/Jira task
• Description contains actions to verify feature/bugfix
• I've built this code, uploaded it to the device and verified feature/bugfix

[equipter]

for reference, this comes at the request of a discord user :P they said they were gonna make an issue later so i had time to kill

[gornekich]

Hello @equipter
Thanks for PR. Will be merged after verification on Skylanders

[gornekich]

Hello @equipter
Skylander figures came to office. After tests I notices that ATQA order check in PR is incorrect. I prepared fix here:
change_atqa_order.txt
You can run git apply change_atqa_order.txt

[V0lk3n]

Hi! @gornekich, i've tested with your change as i noticed the same thing but you was more fast as me. Unfortunately there is one more change to do about the syntax used on mifare_common.c

I've made the change, compiled the FW, tested and it launch the brute force attack now!!!!!!

Here is the updated
change_atqa_order.txt

[V0lk3n]

As proof (sorry in advance if the picture are large im doing it from phone)

[V0lk3n]

Hi! @gornekich, i've tested with your change as i noticed the same thing but you was more fast as me. Unfortunately there is one more change to do about the syntax used on mifare_common.c

I've made the change, compiled the FW, tested and it launch the brute force attack now!!!!!!

Here is the updated change_atqa_order.txt

The change was about change this :

((ATQA0 == 0x01) && (ATQA1 == 0x0F) && (SAK == 0x01))) {//skylanders identification handling

To this

((ATQA0 == 0x01 || ATQA1 == 0x0F) && (SAK == 0x01))) { //skylanders identification handling

[gornekich]

Hi @V0lk3n . I managed to generate sectors keys with algorithm from web cite that you mentioned in Issue, added that keys to User dictionary and read all tag.
We will wait for changed form @equipter and merge this

[V0lk3n]

Hi @V0lk3n . I managed to generate sectors keys with algorithm from web cite that you mentioned in Issue, added that keys to User dictionary and read all tag.
We will wait for changed form @equipter and merge this

So cool! Thanks so much i was going to look at it xD

I ve commented into the PR, the change you mentionned need one more change in my side otherwise he keep didnt detecting it :)

[V0lk3n]

Hi @V0lk3n . I managed to generate sectors keys with algorithm from web cite that you mentioned in Issue, added that keys to User dictionary and read all tag.
We will wait for changed form @equipter and merge this

So cool! Thanks so much i was going to look at it xD

I ve commented into the PR, the change you mentionned need one more change in my side otherwise he keep didnt detecting it :)

Sorry didnt notice that it is the PR and not my issue xD

[gornekich]

No changes. I add it myself #1553