Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3934] Alarm improvements: Snooze, timeouts, and dismissing from the locked state #4017

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

[FL-3934] Alarm improvements: Snooze, timeouts, and dismissing from the locked state #4017

wants to merge 8 commits into from
+96 −7

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Nov 26, 2024 •
edited
Loading

What's new

  • Alarms can be snoozed now
  • Alarms stop ringing after 10 minutes
  • Alarms can now be dismissed even when the device is locked with a PIN

Verification

  • The device locking code has been changed, so locking and unlocking needs to be checked as well

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

Compiled f7 firmware for commit c1c2bca8:

@skotopes skotopes marked this pull request as ready for review December 23, 2024 05:27
skotopes
skotopes requested changes Dec 23, 2024
View reviewed changes
applications/settings/clock_settings/clock_settings_alarm.c Outdated Show resolved Hide resolved
applications/services/gui/gui.c Outdated Show resolved Hide resolved
@skotopes skotopes marked this pull request as draft December 23, 2024 05:59
@skotopes
Copy link
Member

Un-draft when ready

@Astrrra Astrrra marked this pull request as ready for review December 25, 2024 09:40
@Astrrra Astrrra requested a review from skotopes December 25, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Astrrra @skotopes