Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LFRFID: Show ISO-3166 Country Names For Pet Chips #4091

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

zinongli
Copy link
Contributor

What's new

Verification

  1. Read a cute pet and ask them to verify if that indeed is where they come from.
  2. Give them a treat if they said yes.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger
Copy link
Member

hedger commented Feb 3, 2025

This is quite expensive in terms of flash memory consumption. Maybe you could store that data in SD card assets and load on demand?

@hedger hedger added New Feature Contains an IMPLEMENTATION of a new feature RFID 125kHz 125, 134 kHz RFID labels Feb 3, 2025
@zinongli
Copy link
Contributor Author

zinongli commented Feb 3, 2025

Sure. I'll get back to this.

@zinongli zinongli marked this pull request as draft February 3, 2025 18:37
@zinongli
Copy link
Contributor Author

zinongli commented Feb 3, 2025

While looking for ways to assign assets to main apps, I stumbled upon NFC's resource/assets. This country code file seems identical to the look up table we are trying to use here. Is there a way to assign an asset on SD card that can be used by both apps?

I'm fine with mimicing the NFC's process into LFRFID. Just thought maybe I don't have to build the wheel twice.

@zinongli
Copy link
Contributor Author

zinongli commented Feb 3, 2025

Alright. Now it offloads the country list to a .lfrfid resource file. Actually, since it's loading from EXT_PATH, a more unified way to implement this and EMV's country code search would be a single file in a folder in the firmware's ext/asset/ . But since EMV is deprecated for now, it's yor call where to put it. At least this PR works.

@zinongli zinongli marked this pull request as ready for review February 3, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature Contains an IMPLEMENTATION of a new feature RFID 125kHz 125, 134 kHz RFID
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants