Standardize use of furi::time::Duration
#179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarvisCraft
requested changes
Oct 21, 2024
dcoles
force-pushed
the
duration-try-from
branch
from
2c8a988
to
e2d20c5
Compare
Most places use `furi::time::Duration` for things like timeouts, though there are a few place that used `core::time::Duration` (typically before `furi::time::Duration`). I left `furi::thread::sleep` unchanged but introduced a new `sleep_ticks` to specifically support `furi::time::Duration`.
dcoles
force-pushed
the
duration-try-from
branch
from
e2d20c5
to
a973528
Compare
JarvisCraft
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most places use
furi::time::Durationfor things like timeouts, though there are a few place that usedcore::time::Duration(typically beforefuri::time::Duration).I left
furi::thread::sleepunchanged but introduced a newsleep_ticksto specifically supportfuri::time::Duration.