Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

fix(fontawesome): set config.autoAddCss = false #51

Merged
merged 4 commits into from
Jan 27, 2023
Merged

fix(fontawesome): set config.autoAddCss = false #51

merged 4 commits into from
Jan 27, 2023

Conversation

GeorgeMac
Copy link
Member

This fixes one of the blocked resource-related errors we see when we add CSP to Flipt.

https://fontawesome.com/v5/docs/web/other-topics/security#content-security-policy

Before:

Screenshot 2023-01-27 at 11 12 19

After:

Screenshot 2023-01-27 at 11 59 35

@GeorgeMac GeorgeMac requested a review from a team as a code owner January 27, 2023 12:02
@GeorgeMac GeorgeMac mentioned this pull request Jan 27, 2023
Merged
markphelps
markphelps approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘🏻

@markphelps markphelps enabled auto-merge (squash) January 27, 2023 13:37
@markphelps markphelps merged commit 678d0d4 into main Jan 27, 2023
@markphelps markphelps deleted the gm/font-awesome-csp branch January 27, 2023 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markphelps markphelps markphelps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgeMac @markphelps