fix(ui): allow dot in the key of variant (#2887)

* fix(ui): allow dot in the key of variant

closes #2882

* fix issues

ui/src/components/flags/VariantForm.tsx

@@ -16,11 +16,11 @@ import Loading from '~/components/Loading';
 import MoreInfo from '~/components/MoreInfo';
 import { useError } from '~/data/hooks/error';
 import { useSuccess } from '~/data/hooks/success';
-import { jsonValidation, keyValidation } from '~/data/validations';
+import { jsonValidation, keyWithDotValidation } from '~/data/validations';
 import { IVariant, IVariantBase } from '~/types/Variant';
 
 const variantValidationSchema = Yup.object({
-  key: keyValidation,
+  key: keyWithDotValidation,
   attachment: jsonValidation
 });
 

ui/src/data/validation.test.ts

@@ -1,4 +1,4 @@
-import { contextValidation } from './validations';
+import { contextValidation, keyWithDotValidation } from './validations';
 
 describe('contextValidation', () => {
   it('should accept valid input', () => {
@@ -18,3 +18,14 @@ describe('contextValidation', () => {
     expect(result).toEqual(false);
   });
 });
+
+describe('keyWithDotValidation', () => {
+  it('should accept key with dot', () => {
+    const result = keyWithDotValidation.isValidSync('2.0');
+    expect(result).toEqual(true);
+  });
+  it('should not accept key with invalid values', () => {
+    const result = keyWithDotValidation.isValidSync('key]');
+    expect(result).toEqual(false);
+  });
+});

ui/src/data/validations.ts

@@ -7,6 +7,13 @@ export const keyValidation = Yup.string()
     'Only letters, numbers, hypens and underscores allowed'
   );
 
+export const keyWithDotValidation = Yup.string()
+  .required('Required')
+  .matches(
+    /^[-_,A-Za-z0-9.]+$/,
+    'Only letters, numbers, hypens, dots and underscores allowed'
+  );
+
 export const requiredValidation = Yup.string().required('Required');
 
 export const jsonValidation = Yup.string()