Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap to http.Method* Constants #1080

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

syntaqx
Copy link
Contributor

@syntaqx syntaqx commented Oct 19, 2022

Such a minor thing, but swapping the HTTP method strings to the available constants.

@codecov-commenter
Copy link

Codecov Report

Merging #1080 (422bfce) into main (83469f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1080   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files          26       26           
  Lines        1954     1954           
=======================================
  Hits         1586     1586           
  Misses        285      285           
  Partials       83       83           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@markphelps
Copy link
Collaborator

@all-contributors please add @syntaqx for code

@allcontributors
Copy link
Contributor

@markphelps

I've put up a pull request to add @syntaqx! 🎉

@markphelps
Copy link
Collaborator

Thanks @syntaqx ! Cheers

@markphelps markphelps merged commit bbc62de into flipt-io:main Oct 19, 2022
@syntaqx syntaqx deleted the http-method-consts branch October 21, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants