chore: switch to official redis client and redis-cache/v9 #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1345 +/- ##
==========================================
+ Coverage 80.47% 80.65% +0.17%
==========================================
Files 43 43
Lines 3375 3375
==========================================
+ Hits 2716 2722 +6
+ Misses 527 523 -4
+ Partials 132 130 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
markphelps
added a commit
that referenced
this pull request
Feb 22, 2023
* main: feat: enable ability to specify bootstrap token (#1350) feat(auth/k8s): kubernetes auth method service implementation (#1344) feat(rpc/auth): define AuthenticationMethodKubernetesService proto (#1341) chore: fix dependencies after testcontainers-go bump (#1349) chore(deps): bump github.com/testcontainers/testcontainers-go (#1348) chore(deps): bump golang.org/x/net from 0.6.0 to 0.7.0 (#1347) chore: switch to official redis client and redis-cache/v9 (#1345) chore(deps): bump golang.org/x/net from 0.6.0 to 0.7.0 in /_tools (#1346)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-redishas moved under the official 'redis' org: https://redis.com/blog/go-redis-official-redis-client/This PR updates to use this new version (v9) and also updates the
redis/cachelib to also bev9.This change will allow us to add tracing/metrics to our cache since
v9now supportsotel: https://redis.uptrace.dev/guide/go-redis-monitoring.htmlex: https://github.com/redis/go-redis/blob/master/example/otel/client.go#L35-L40