-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): move hack/build into build #1493
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1493 +/- ##
=======================================
Coverage 77.79% 77.79%
=======================================
Files 46 46
Lines 3611 3611
=======================================
Hits 2809 2809
Misses 639 639
Partials 163 163 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.. i'm getting some failures trying to run mage test:integration
from within the build dir locally.. but it could just be a me/environmental thing
#4
#4 0.199 host alias: lookup 59ITLR5UJJHHI on 10.87.0.1:53: no such host
#4 0.422 host alias: lookup V65VEQ5F2IIHU on 10.87.0.1:53: no such host
#4 0.448 host alias: lookup 2LT67EKMRPRLU on 10.87.0.1:53: no such host
#4 ...
Hmm strange, I haven't managed to replicate that. I have seen that particular error before, it has to do with the |
Fixes FLI-308
Moves
hack/build
contents into justbuild
.I fixed up a small break in the unit test workflow too.
This broke when we moved the UI back into this repository.
We're not currently running unit tests via dagger, just integration, so this went unnoticed.