-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(internal/ext): add 1.1 to versions and validate explicit 1.2 #2042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! lets rebase onto release/1.25
branch and we can get a patch release out
Codecov Report
@@ Coverage Diff @@
## main #2042 +/- ##
=======================================
Coverage 70.62% 70.62%
=======================================
Files 72 72
Lines 6821 6821
=======================================
Hits 4817 4817
Misses 1733 1733
Partials 271 271
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
* fix(internal/ext): add 1.1 to versions and validate explicit 1.2 * chore(internal/ext): remove redundent idGen field * chore: skip unparam for function receiving constant --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…to mp/monaco-redo * 'mp/monaco-redo' of https://github.com/flipt-io/flipt: chore: fix nightly build; add footer to release notes on GH (#2041) chore: bump changelog for 1.25.2 fix(internal/ext): add 1.1 to versions and validate explicit 1.2 (#2042) chore: update go mod fix(internal/ext): add 1.1 to versions and validate explicit 1.2 (#2042) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (#2037) chore(deps-dev): bump postcss from 8.4.27 to 8.4.28 in /ui (#2028) chore: change parameter name of PKCE feat(oidc): Add parameters for pkce flow
A user reported a couple issues which this PR addresses.
1.1
was being reported as "unsupported"1.2
it also produced errorsThis was due to a couple issues.
1.1
in the supported versions lists ininternal/ext
.1.2
to the validation of the CUE schema.We will add some better regression testing in a later PR.
For now I have attempted to improve the unit tests in these packages with more of the missing cases.