Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rework tests for TLS options for git sources with self-sign… #2473

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

erka
Copy link
Contributor

@erka erka commented Nov 30, 2023

rework tests for TLS options for git sources with self-signed certificates

Refs: #2443

@erka erka requested a review from a team as a code owner November 30, 2023 15:31
@erka erka force-pushed the rework-ca-cert-tests branch from 305f4af to 6156e53 Compare November 30, 2023 15:35
Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10bfcbc) 70.72% compared to head (6156e53) 70.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2473   +/-   ##
=======================================
  Coverage   70.72%   70.72%           
=======================================
  Files          81       81           
  Lines        8139     8139           
=======================================
  Hits         5756     5756           
  Misses       2036     2036           
  Partials      347      347           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GeorgeMac GeorgeMac merged commit 2bea7c9 into flipt-io:main Nov 30, 2023
@erka erka deleted the rework-ca-cert-tests branch November 30, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants