-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui/console): add copy as curl button #2474
feat(ui/console): add copy as curl button #2474
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2474 +/- ##
=======================================
Coverage 70.73% 70.73%
=======================================
Files 81 81
Lines 8130 8130
=======================================
Hits 5751 5751
Misses 2033 2033
Partials 346 346 ☔ View full report in Codecov by Sentry. |
457feff
to
4192b14
Compare
@AmineRhazzar could you please change |
This is really awesome, thank you @AmineRhazzar 🙏 I think what you have there for auth makes sense. We could have a little input field for supplying a token, but unsure if we really want that and could always come in a later change if we decided we want it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome and thanks for fixing the highlighting bug too!
You're welcome! Happy to help |
| 'METHOD_TOKEN' | ||
| 'METHOD_OIDC' | ||
| 'METHOD_GITHUB' | ||
| 'METHOD_KUBERNETES'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple minor suggestions @AmineRhazzar
thank you very much for doing this! works great!
@all-contributors please add @AmineRhazzar for code |
I've put up a pull request to add @AmineRhazzar! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks again @AmineRhazzar !!
My pleasure 👌 |
fixes: #2255
I wasn't sure how to specify the need for an API token for the curl command if auth was required. I just put
-H "Authorization: Bearer <api-token>"
.